Add additional unit tests #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #217 +/- ## ========================================== + Coverage 68.31% 68.46% +0.14% ========================================== Files 107 107 Lines 7334 7334 Branches 1388 1388 ========================================== + Hits 5010 5021 +11 + Misses 1868 1867 -1 + Partials 456 446 -10
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've been taking a look at your project and have identified some classes which could potentially benefit from increased code coverage. The regression tests contained in this PR should catch some edge cases that haven't yet been covered by your existing tests for these classes. They'll help you identify any unexpected behaviour in your code as you continue to develop your project.
I'd be happy to help create some more tests for your project should you wish!