Skip to content

Conversation

keremulutas
Copy link
Contributor

@keremulutas keremulutas commented Sep 11, 2017

Added the "mustBeValid" and "test_not_found" methods.

I had to change the JsonException exception field of NotFoundAny from private to protected, so that I could access the exact reason of value being not found.

When I run the tests I have 12 failed - even if I clone your repo and run the tests without any changes - I can't tell if there is a problem with the code I introduced. Sorry for the inconvenience.

@codecov-io
Copy link

Codecov Report

Merging #100 into master will increase coverage by 4.14%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #100 +/- ## ========================================== + Coverage 67.59% 71.74% +4.14%  ========================================== Files 90 90 Lines 6404 6409 +5 Branches 1225 1230 +5 ========================================== + Hits 4329 4598 +269  + Misses 1660 1405 -255  + Partials 415 406 -9
Impacted Files Coverage Δ
src/main/java/com/jsoniter/any/NotFoundAny.java 60.86% <ø> (+3.72%) ⬆️
src/main/java/com/jsoniter/any/Any.java 58.18% <0%> (-2.01%) ⬇️
.../main/java/com/jsoniter/CodegenImplObjectHash.java 28.8% <0%> (-64.8%) ⬇️
src/main/java/com/jsoniter/Codegen.java 46.42% <0%> (-11.31%) ⬇️
src/main/java/com/jsoniter/IterImpl.java 61.76% <0%> (-5.15%) ⬇️
...c/main/java/com/jsoniter/output/CodegenResult.java 85.33% <0%> (-0.78%) ⬇️
...ain/java/com/jsoniter/CodegenImplObjectStrict.java 84.14% <0%> (-0.25%) ⬇️
src/main/java/com/jsoniter/spi/GenericsHelper.java 44.89% <0%> (ø) ⬆️
...java/com/jsoniter/extra/NamingStrategySupport.java
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411647c...04b2025. Read the comment docs.

@taowen taowen merged commit 295265a into json-iterator:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants