Map keys of custom types should serialize using MarshalText when available #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #461 +/- ## ========================================== - Coverage 86.63% 86.22% -0.42% ========================================== Files 41 41 Lines 5103 5103 ========================================== - Hits 4421 4400 -21 - Misses 541 562 +21 Partials 141 141
Continue to review full report at Codecov.
|
| Thanks for the bug report and the patch.
|
- this brings unmarshaling behavior in line with encoding/json - in general, any types that implement the interfaces from the encoding package (TextUnmarshaler, TextMarshaler, etc.) should use the provided method when available - this commit also moves test cases from jsoniter_map_test.go to value/tests/map_test.go
| Thanks for the feedback.
|
| @AllenX2018 ping! |
| Merged, Thanks! |
zhenzou pushed a commit to zhenzou/jsoniter that referenced this pull request Feb 2, 2022
…lable (json-iterator#461) * Map keys of custom types should serialize/deserialize using MarshalText/UnmarshalText when available - this brings marshaling/unmarshaling behavior in line with encoding/json - in general, any types that implement the interfaces from the encoding package (TextUnmarshaler, TextMarshaler, etc.) should use the provided method when available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is to address the issue filed here.