Remove nil == nil if-statement #420
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Found using the nilness analysis: ``` $ go install golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness $ go vet -vettool=$(which nilness) \# github.com/json-iterator/go ./iter_object.go:241:10: tautological condition: nil == nil ```
Codecov Report
@@ Coverage Diff @@ ## master #420 +/- ## ========================================== + Coverage 86.46% 86.52% +0.05% ========================================== Files 41 41 Lines 5105 5104 -1 ========================================== + Hits 4414 4416 +2 + Misses 555 552 -3 Partials 136 136
Continue to review full report at Codecov.
|
| Is it correct that |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Found using the nilness analysis: