fix(processTags): remove extra qoutes that added to slice and map type #407
Conversation
when use json tag have a string value it should convert numbers and boolean to string but iy should not add qoutes to slice and map type as go json package do. issue json-iterator#395
m-amr force-pushed the fix_marshel_non_string_type_with_string_json_tag branch from 9b1354e to 3c4fb2b Compare 
Codecov Report
@@ Coverage Diff @@ ## master #407 +/- ## ======================================= Coverage 81.72% 81.72% ======================================= Files 41 41 Lines 5029 5029 ======================================= Hits 4110 4110 Misses 798 798 Partials 121 121
Continue to review full report at Codecov.
|
| please include tests for the bug |
| @taowen Do you need to add more test cases ? I think that the coverage decreased because
|
| IMO, if the field's type is struct or implements |
| c = iter.readByte() | ||
| if c != '"' { | ||
| iter.ReportError("stringModeNumberDecoder", `expect ", but found `+string([]byte{c})) | ||
| iter.ReportError("stringModeNonStringDecoder", `expect ", but found `+string([]byte{c})) |
There was a problem hiding this comment.
Maybe it needs a testcase to cover these new added lines to avoid the coverage diff reported by codecov.
3 participants
when use json tag have a string value it should convert numbers and boolean to string
but it should not add qoutes to slice and map type as go json package do.
issue #395