Make case sensitivity optional

[caesarxuchao]

Fix kubernetes/kubernetes#64612

[codecov]

Codecov Report

Merging #282 into master will increase coverage by 0.05%.
The diff coverage is 63.63%.

@@ Coverage Diff @@ ## master #282 +/- ## ========================================== + Coverage 81.27% 81.32% +0.05%  ========================================== Files 41 41 Lines 4971 4979 +8 ========================================== + Hits 4040 4049 +9  + Misses 814 810 -4  - Partials 117 120 +3

Impacted Files	Coverage Δ
config.go	88.7% <100%> (+0.06%)	⬆️
iter_object.go	64.97% <42.85%> (-1.13%)	⬇️
reflect.go	92.63% <50%> (-0.92%)	⬇️
reflect_struct_decoder.go	45.88% <80%> (+0.83%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8744d7c...b92cf78. Read the comment docs.

[caesarxuchao]

I tried unit tests on the master branch and many tests were broken. I suspect it's caused by dependency issues? I used "dep ensure" to download dependencies. It's much appreciated If you have some pointers on how to solve the local unit test failures.

go test ./... output: https://raw.githubusercontent.com/caesarxuchao/go/test/testlog

[sai-g]

@caesarxuchao I faced the similar issue in running tests. I used the following command to fetch test dependencies, and it worked go get -t ./...

[caesarxuchao]

Thanks @sai-g. I also installed the json-iter/go at the wrong path. After moving it to $GOPATH/github.com/json-iterator/go, and run go get -t ./..., I'm able to pass the test locally.

[liggitt]

Does this code above also make decoding case-insensitive?

for k, binding := range bindings { if _, found := fields[strings.ToLower(k)]; !found { fields[strings.ToLower(k)] = binding.Decoder.(*structFieldDecoder) } } 

[liggitt]

A test case that exercises positive and negative cases would be good

[nikhita]

Opened #285

[nikhita]

Does this code above also make decoding case-insensitive?

Yes, this was the culprit.