Skip to content

Coding guidelines cibuild #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 8, 2021
Merged

Coding guidelines cibuild #962

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
de94269
Added inspectcode/cleanupcode scripts and cibuild validation
Mar 3, 2021
2092ad5
Added missing formatting directives to HostingFakers
Mar 3, 2021
30b46f6
Auto-formatted codebase using Resharper
Mar 3, 2021
1a64287
Fixed broken build after reformat
Mar 3, 2021
21afcd9
Replaced "var _" with discards
Mar 3, 2021
eca88ed
Fixed a few single-letter variable names
Mar 3, 2021
5d2b18b
Fixed broken custom pattern suggestion
Mar 3, 2021
549a6f6
Test: fail the build with an inspectcode warning
Mar 3, 2021
2d4714b
Test: fail the build with formatting violations
Mar 3, 2021
228f021
Revert "Test: fail the build with formatting violations"
Mar 4, 2021
ee4ec3f
Revert "Test: fail the build with an inspectcode warning"
Mar 4, 2021
5d7d59f
Updated documentation to match with new style
Mar 4, 2021
441a235
Updated contributing guidelines
Mar 4, 2021
d392e1d
Empty commit
Mar 4, 2021
846e686
Added download link for PowerShell
Mar 5, 2021
23d871f
Added note on injected severities layer
Mar 6, 2021
4d59155
Added link to contributing guidelines
Mar 6, 2021
cf763fc
Merge branch 'master' into coding-guidelines-cibuild
Mar 6, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added download link for PowerShell
  • Loading branch information
Bart Koelman committed Mar 5, 2021
commit 846e6867fa7b5d25e35b3d30953b396600e4a8fa
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Please follow these steps to have your contribution considered by the maintainer
- After you submit your pull request, verify that all status checks are passing. In release builds, all compiler warnings are treated as errors, so you should address them before push.

We use [CSharpGuidelines](https://csharpcodingguidelines.com/) as our coding standard (with a few minor exceptions). Coding style is validated during PR build.
You can run the following scripts locally:
You can run the following [PowerShell scripts](https://github.com/PowerShell/PowerShell/releases) locally:
- `inspectcode.ps1`: Scans the code for style violations and opens the result in your web browser.
- `cleanupcode.ps1` Reformats the entire codebase to match with our configured style.

Expand Down