Skip to content

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Mar 18, 2024

Follow-up of the changes in #1506 and #1503. This PR moves [FromBody] back on base controllers, to prevent a breaking change.

Effectively (all PRs combined), only [Required] is being added on non-base controllers, so that Swashbuckle makes request bodies required.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (7e864a2) to head (2dcf65d).

Additional details and impacted files
@@ Coverage Diff @@ ## master #1508 +/- ## ======================================= Coverage 90.78% 90.78% ======================================= Files 346 346 Lines 11044 11044 Branches 1813 1813 ======================================= Hits 10026 10026 Misses 669 669 Partials 349 349 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review March 18, 2024 00:32
@bkoelman bkoelman merged commit c3e23da into master Mar 18, 2024
@bkoelman bkoelman deleted the revert-frombody-changes branch March 18, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant