React Native 0.28 update #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| CI is failing due to sections of the module that haven't been touched as part of this PR... can confirm it works fine in production, though! |
| +1 |
| +1 Please merge |
| +1 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updates the module to work correctly under RN v0.28. The main breaking change was that RN no longer permits 'react-native' as an alias for 'react'. Also, ActivityIndicatorIOS has been deprecated in favor of the more general ActivityIndicator.
This resolves issues #58, #54.
Note: long-term, this module should be deprecated in favor of https://facebook.github.io/react-native/docs/refreshcontrol.html - for those who are stuck with it as a dependency for now, though, this PR should allow you to run the latest version of React Native until you get around to migrating to the native solution :)