Skip to content

Add support for strikethrough text style #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2018
Merged

Add support for strikethrough text style #210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d27169
Add support for strike through style on Android
macgregorthomson Mar 12, 2018
cae1f28
Add support for deprecated `strike` tag
macgregorthomson Mar 12, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions HTMLView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {Linking, Platform, StyleSheet, View, ViewPropTypes} from 'react-native';
const boldStyle = {fontWeight: '500'};
const italicStyle = {fontStyle: 'italic'};
const underlineStyle = {textDecorationLine: 'underline'};
const strikethroughStyle = {textDecorationLine: 'line-through'};
const codeStyle = {fontFamily: Platform.OS === 'ios' ? 'Menlo' : 'monospace'};

const baseStyles = StyleSheet.create({
Expand All @@ -14,6 +15,8 @@ const baseStyles = StyleSheet.create({
i: italicStyle,
em: italicStyle,
u: underlineStyle,
s: strikethroughStyle,
Copy link

@TooManyBees TooManyBees Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also add this for the deprecated strike tag, given that this code also recognizes the old b and i tags
Copy link
Contributor Author

@macgregorthomson macgregorthomson Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TooManyBees 👍
strike: strikethroughStyle,
pre: codeStyle,
code: codeStyle,
a: {
Expand Down