Selectmenu

[jzaefferer]

New PR for selectmenu, since #492 got too long.

See also http://wiki.jqueryui.com/w/page/12138056/Selectmenu

[fnagel]

Any feedback on my latest comments?

[jzaefferer]

@fnagel once you've addressed those four we just discussed, can you close this PR and create a new one, once more? Then we can do a (hopefully) final review there.

[fnagel]

@jzaefferer Yes, I will pen a new one.

There is one thing I mentioned in a comment above:

I noticed an issue in IE8 and IE7: the change event unit test fails. The change event wont fire but it fails only in the unit test. It works when used by actual mouse / keyboard interaction. Any ideas? 

[scottgonzalez]

Perhaps related to the fact that you're treating .simulate( "focus" ) as synchronous, while focus is always async in IE.

[fnagel]

@scottgonzalez I've changed to asyncTest but that didn't help.

[scottgonzalez]

We were able to track down the problem to .simulate( "click" ) and delegated events. Can you go through the tests and change all of the instances of .simulate( "click" ) to just .trigger( "click" ) and see if everything continues to pass for you? We'll probably want to write a real click simulation at some point that handles mouse down, up, etc.

[scottgonzalez]

To remove the looping, you can add something like this inside _move():

if ( this.menu.menu( "isFirstItem" ) && /^previous/.test( direction ) || this.menu.menu( "isLastItem" ) && /^next/.test( direction ) ) { return; }

We'll need tests for this as well.