Better image compression for base theme images #609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Author
| It looks like I wasn't first who came up with this idea… #556 |
| I socond this one |
Member
| Thanks, unfortunately this isn't really where the problem needs to be fixed. We generate themes in PHP and the optimization has to happen there for it to be effective. This is something that needs to wait until we write the new version of ThemeRoller. |
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These are same images (only loseless methods were used) as ones used in base theme but heavily optimized for web. This set was used in Yii framework jQueryUI bundle since 07/04/2011 without any issues.