Core: switchClass style lazy evaluation #6244 #40
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
In the ticket, the user is trying to change an element's class using switchClass multiple times, going from .blue to .red to .green and back to .blue.
Because switchClass evaluates the style of the element when switchClass is called and not when it runs, the animation didn't work correctly.
My fix uses the jQuery queue to evaluate the style of the element (and style difference) immediately before it is going to be used in the animation, allowing chaining and delays to work with no issue.
This is my first attempt at working on this project, so please let me know if I need to do anything else.
-Alex