Mouse: tie the preventClickEvent property to the event target, not the container. Fixes #4752 - link event firing on sortable with connect list #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…e container. Fixes #4752 - link event firing on sortable with connect list
| Landed in e2a693b Thanks! |
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since a sortable helper can change hands during sorting, the current method of preventing a click event breaks when an element moves from one sortable to another. To fix this, I've tied the
preventClickEventproperty to the event target instead of the widget.This fixes #4752 (http://dev.jqueryui.com/ticket/4752). I'm resubmitting this pull request as a new one, since the old one was open for over two months. Hopefully this one will be easier to pull/merge.