Autocomplete: Trigger search timeout on all input events. Fixes #6666 #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Triggering a custom event is an interesting idea, but comes with unnecessary overhead - why not just just add a method to the widget instance and call that instead? |
… - keyboard-autorepeat on Firefox and paste event The input event triggers after all changes to an input field including paste/cut events.
| Good point. I changed the patch to use a widget method instead of a custom event. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a follow up to pull request #186.
This change fixes issue #666 (keyboard-autorepeat on Firefox and paste event).
I moved the search timeout used for all generic key presses into its own event binding. This event is then called on
keypressandinputevents. Theinputevent is needed becausekeydown,keyup, andkeypressevents are not triggered triggered when pasting text with the mouse.