Skip to content

Tooltip: Don't crash on empty content #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2021
Merged

Tooltip: Don't crash on empty content #1994

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c5aef9b
Widget & Tooltip: Regression from 1.12.1
josepsanzcamp Oct 8, 2021
1a9947f
Widget & Tooltip: Regression from 1.12.1
josepsanzcamp Oct 12, 2021
dea398b
Update ui/widgets/tooltip.js
josepsanzcamp Oct 12, 2021
8a07975
Update ui/widgets/tooltip.js
josepsanzcamp Oct 15, 2021
f8f320a
Widget & Tooltip: Regression from 1.12.1
josepsanzcamp Oct 30, 2021
b6150dc
Tooltip: Fix a reference to a GitHub issue
mgol Nov 7, 2021
d29cb28
Apply suggestions from code review
mgol Nov 8, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@mgol
mgol authored Nov 8, 2021
commit d29cb28387e969f0a04c4ddd8bc5d7bb5039b4c2
4 changes: 2 additions & 2 deletions tests/unit/tooltip/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ QUnit.test( "remove conflicting attributes from live region", function( assert )
} );

// gh-1990
QUnit.test( "widget and tooltip regression from 1.12.1", function( assert ) {
QUnit.test( "don't crash on empty tooltip content", function( assert ) {
var ready = assert.async();
assert.expect( 1 );

Expand Down Expand Up @@ -317,7 +317,7 @@ QUnit.test( "widget and tooltip regression from 1.12.1", function( assert ) {
"close:anchortitle",
"open:anchortitle",
"close:anchortitle"
], "The tooltip open and close" );
], "Tooltip opens and closes without crashing" );
ready();
}

Expand Down