Skip to content

Conversation

mgol
Copy link
Member

@mgol mgol commented Mar 7, 2021

Some bad pages are being detected as Catalan randomly which makes the build
fail. This is reproducible both locally & on Travis. This commit adds a new
regex to account for this error.

Some bad pages are being detected as Catalan randomly which makes the build fail. This is reproducible both locally & on Travis. This commit adds a new regex to account for this error.
@mgol mgol added this to the 1.13 milestone Mar 7, 2021
@mgol mgol requested review from arschmitz and fnagel March 7, 2021 13:23
@mgol
Copy link
Member Author

mgol commented Mar 7, 2021

You can see an example of this failure on Travis here: https://travis-ci.com/github/mgol/jquery-ui/jobs/488832293. I don't understand why it only happens on some builds...

Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

@mgol mgol merged commit 1029849 into jquery:main Mar 8, 2021
@mgol mgol deleted the htmllint-error branch March 8, 2021 23:10
mgol added a commit to mgol/jquery-ui that referenced this pull request Mar 9, 2021
Some bad pages are being detected as Catalan randomly which makes the build fail. This is reproducible both locally & on Travis. PR jquerygh-1949 added a new regex to account for this error but it didn't escape parens properly so it's not matching the problematic error message. Ref jquerygh-1949
mgol added a commit that referenced this pull request Mar 10, 2021
Some bad pages are being detected as Catalan randomly which makes the build fail. This is reproducible both locally & on Travis. PR gh-1949 added a new regex to account for this error but it didn't escape parens properly so it's not matching the problematic error message. Ref gh-1949 Closes gh-1950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants