Tests: Solve a frequent race condition in tests in Chrome/Safari #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dmethvin approved these changes May 15, 2020
Member
dmethvin left a comment
dmethvin left a comment There was a problem hiding this comment.
I don't wanna know how you found this one.
arschmitz approved these changes May 15, 2020
Member Author
Don't you? ;) I saw that the test was only failing every other run locally so I had a look at what it does. When it was failing, it was reporting |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Give browsers some time to load the image if cache is disabled.
This resolves a frequent issue in Chrome/Safari.