Skip to content

Remove useless IE8 code, fixes bug. #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Remove useless IE8 code, fixes bug. #1893

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ecb251a
Remove useless IE8 code, fixes bug.
joejoseph00 Aug 1, 2019
ec011a2
anonymous function
joejoseph00 Aug 2, 2019
518e367
Revert "anonymous function"
Aug 20, 2019
0a1b4dc
Revert "Remove useless IE8 code, fixes bug."
Aug 20, 2019
975a6d5
Remove IE8 support that crashes in some cases (in my case using Drupa…
Aug 20, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@
// Support: IE8 Only
// IE8 does not support the form attribute and when it is supplied. It overwrites the form prop
// with a string, so we need to find the proper form.
// However since we no longer need to support IE8 we can just return the form attribute.
return $.fn._form = function() {
return typeof this[ 0 ].form === "string" ? this.closest( "form" ) : $( this[ 0 ].form );
return $( this[ 0 ].form );
};

} ) );