Resizable: Keep user defined handles on _setOption #1795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
| Thanks, I'll try to review this in a few hours. But I wanted to respond about the destroy behavior. Any elements that were created by the user should remain after destroy. |
| You're welcome :) Do you want me to include the destroy logic to this PR, or should I create a new one? |
| I guess since this destroy behavior has been in place for a while, it can be a separate PR. |
| Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Now handles that have been placed in the DOM by the user will persist through _setOption. However, I noticed they will be removed on destroy. I'm not certain if this is expected. If not, I can fix that as well.
Fixes #15084
Related to #1666