- Notifications
You must be signed in to change notification settings - Fork 5.3k
Core: Split up into individual modules #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 39 commits
Commits
Show all changes
41 commits Select commit Hold shift + click to select a range
5d2a975
Core: Move version and creation of the ui namespace into its own module
arschmitz 80014cc
Core: Move data selector from core into its own module
arschmitz eadd138
Core: Move disable-selection into its own module
arschmitz cb4b685
Core: Move focusable into its own module
arschmitz e0b0173
Core: Move escape selector into its own module
arschmitz 31894df
Core: Move form method into its own module
arschmitz 7f2b1fe
Core: Move $.ui.ie into its own module
arschmitz 14362e7
Core: Move keyCode into its own module
arschmitz acc9d4f
Core: Move labels into its own module
arschmitz 7944f56
Core: Move backcompat for core 1.7 into its own module
arschmitz ac53bb4
Core: Move plugin into its own module
arschmitz c878e93
Core: Move safeActiveElement into its own module
arschmitz 53c688f
Core: Move safe blur into its own module
arschmitz c81e802
Core: Move tabbable into its own module
arschmitz d17cd0b
Core: Move scrollParent into its own module
arschmitz 97a39d2
Core: Movie uniqueId into its own module
arschmitz b1bc229
Demos: bootstrap needs to account for widgets folder
arschmitz 216ea1a
Accordion: Move accordion into widgets folder
arschmitz 9979e53
Autocomplete: Move autocomplete into widgets folder
arschmitz 326e599
Button: Move button into widgets folder
arschmitz 000d560
Datepicker: Move datepicker into widgets folder
arschmitz 8ddbdec
Dialog: Move dialog into widgets folder
arschmitz 950d841
Draggable: Move draggable into widgets folder
arschmitz 7a930da
Effects: Move individual effects into effects folder
arschmitz 0283e1d
Droppable: Move droppable into widgets folder
arschmitz d24b67c
Menu: Move menu into widgets folder
arschmitz 9899075
Progressbar: Move progressbar into widgets folder
arschmitz d4a8d5d
Mouse: Move mouse into widgets folder
arschmitz e97ac81
Resizable: Move resizable into widgets folder
arschmitz 41224d6
Selectable: Move selectable into widgets folder
arschmitz 8825220
Selectmenu: Move selectmenu into widgets folder
arschmitz 1d1c568
Slider: Move slider into widgets folder
arschmitz b034c9b
Sortable: Move sortable into widgets folder
arschmitz 93fe76a
Spinner: Move spinner into widgets folder
arschmitz 7e47dc0
Tabs: Move tabs into widgets directory
arschmitz d2c23a0
Tooltip: Move tooltip into widgets directory
arschmitz 4af1475
Tests: adjust jshint path for moving all widgets into folder
arschmitz b292e05
Datepicker: move to widgts fixup
arschmitz 3cdae44
Build: Add requirejs build task
arschmitz 7a13ee3
Build: Remove grunt concat task its no longer used
arschmitz 7ac49fa
Core: fixup remove demos link
arschmitz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
define( [ | ||
"lib/common", | ||
"ui/button" | ||
"ui/widgets/button" | ||
], function( common ) { | ||
| ||
common.testWidget( "button", { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
define( [ | ||
"jquery", | ||
"ui/button" | ||
"ui/widgets/button" | ||
], function( $ ) { | ||
| ||
module("button: core"); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
define( [ | ||
"jquery", | ||
"ui/button" | ||
"ui/widgets/button" | ||
], function( $ ) { | ||
| ||
module("button: events"); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
define( [ | ||
"jquery", | ||
"ui/button" | ||
"ui/widgets/button" | ||
], function( $ ) { | ||
| ||
module("button: methods"); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
define( [ | ||
"jquery", | ||
"ui/button" | ||
"ui/widgets/button" | ||
], function( $ ) { | ||
| ||
module( "button: options" ); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
define( [ | ||
"lib/common", | ||
"ui/dialog" | ||
"ui/widgets/dialog" | ||
], function( common ) { | ||
| ||
common.testWidget( "dialog", { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
define( [ | ||
"lib/common", | ||
"ui/dialog" | ||
"ui/widgets/dialog" | ||
], function( common ) { | ||
| ||
common.testWidget( "dialog", { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks strange - the logic is the same as for the
widgets
list, but the "effects/" prefix is part of the list, don't you end up with "effects/effects/..."?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an error here it needs to check if it contains the string not
===
because this is processing when a demo requires a specific effect not all the effects.