Dialog: Stop tracking instance in destroy() to avoid memory leaks #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ui/dialog.js Outdated
There was a problem hiding this comment.
Can't you just call ._untrackInstance()?
There was a problem hiding this comment.
Yeah I like that name better.
There was a problem hiding this comment.
He didn't mean rename it, he meant there's already a function that does this, and it's called _untrackInstance().
There was a problem hiding this comment.
Yeah that method works and it's even written nicer than mine. Changed.
Fixes #11125 Closes jquerygh-1448
tjvantoll force-pushed the dialog-leak branch from d4f2556 to 4b6583c Compare 
| I approve of this one line change ;-) |
| 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #11125