Make the supported types an internal variable #34
+6 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This allows a user to override the custom types. For example, one can do ``` binarytree._ATTR_VALUE_TYPES = (float, int, np.uint8) class CustomNode(binarytree.Node): pass ``` Ideally, the attributes should be members of the nodes. That would allow a user to override a lot of different options, s.a. how the values are printed, what to do with the long strings, etc.
joowani approved these changes Jan 29, 2022
| Sorry for the late reply @z-a-f and thank you for the contribution! lgtm |
| Actually this is failing both black and mypy so I'm going to have to revert. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This allows a user to override the custom types. For example, one can do
Ideally, the attributes should be members of the nodes. That would allow a user to override a lot of different options, s.a. how the values are printed, what to do with the long strings, etc.