Propose Opcache invalidation on file operations #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Contributor Author
| Another PR, another drive by thumbs down from @SharkyKZ - why do you do this without commenting what you dont like...
|
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Contributor Author
| renamed method as requested joomla/joomla-cms#32915 (comment) |
Contributor
| Thank you! |
Contributor
| This shouldn't have been merged. |
Contributor Author
| but for the fourth time ... I ask you ... WHY? You can't just go around closing PRs and shouting its wrong without explaining why. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary of Changes
On write or delete of a file, invalidate the opcache for that file, so that changes are loaded into memory on servers with opcache caching set to maximum, or incorrect configured, or set to preload/never revalidate.
Testing Instructions
everything should work as before.
If you really want to test then install php with opcache preload and revalidate timestamps set to never, and use an opcache gun to view what's in the cache, make a change to a file using this class, and compare what is in the cache after.
Documentation Changes Required
none
Why/History
Experience: joomla/joomla-cms#32592
Joomla 3 joomla/joomla-cms#32918
Joomla 4 joomla/joomla-cms#32915