Skip to content

Remove mootools #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbabker merged 3 commits into from
May 5, 2015
Merged

Remove mootools #82

mbabker merged 3 commits into from
May 5, 2015

Conversation

@dgrammatiko
Copy link

@dgrammatiko dgrammatiko commented May 5, 2015

Mootools is not needed here, so lets drop it!
Also the inline script is better to go through API
Remove mootools
d459978 
Mootools is not needed here, so lets drop it! Also the inline script is better to go through API
@mbabker
Copy link

mbabker commented May 5, 2015

This doesn't kill the modal for the fetch process, does it?
Dimitris Grammatiko added 2 commits May 6, 2015 02:40
@dgrammatiko
Copy link
Author

dgrammatiko commented May 5, 2015

No the fetch is jquery: https://github.com/joomla-extensions/patchtester/blob/master/media/com_patchtester/js/fetcher.js#L12
@dgrammatiko
Copy link
Author

dgrammatiko commented May 5, 2015

@mbabker the modal is bootstrap https://github.com/joomla-extensions/patchtester/blob/master/administrator/components/com_patchtester/PatchTester/View/Pulls/PullsHtmlView.php#L106-L117
@mbabker
Copy link

mbabker commented May 5, 2015

Ya that's what I couldn't remember off hand, if a Bootstrap modal was being used or if it was the older Squeezebox one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dgrammatiko @mbabker