Skip to content

Add trailing slash to site_url #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add trailing slash to site_url #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mike/mkdocs_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def on_config(self, config):
if version and config.get('site_url'):
if self.config['canonical_version'] is not None:
version = self.config['canonical_version']
config['site_url'] = urljoin(config['site_url'], version)
config['site_url'] = urljoin(config['site_url'], version) + '/'

def on_files(self, files, config):
if not self.config['version_selector']:
Expand Down
4 changes: 2 additions & 2 deletions test/unit/test_mkdocs_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def test_site_url(self):
with mock.patch('os.environ', {docs_version_var: '1.0'}):
config = {'site_url': 'https://example.com/'}
self.make_plugin().on_config(config)
self.assertEqual(config['site_url'], 'https://example.com/1.0')
self.assertEqual(config['site_url'], 'https://example.com/1.0/')

def test_no_site_url(self):
with mock.patch('os.environ', {docs_version_var: '1.0'}):
Expand All @@ -46,7 +46,7 @@ def test_explicit_canonical(self):
with mock.patch('os.environ', {docs_version_var: '1.0'}):
config = {'site_url': 'https://example.com/'}
self.make_plugin(canonical_version='latest').on_config(config)
self.assertEqual(config['site_url'], 'https://example.com/latest')
self.assertEqual(config['site_url'], 'https://example.com/latest/')

with mock.patch('os.environ', {docs_version_var: '1.0'}):
config = {'site_url': 'https://example.com/'}
Expand Down