Intro idr.Node's xpath.NodeNavigator impl: navigator. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Code/algo mostly inherits from https://github.com/antchfx/xmlquery/blob/master/query.go but the primary difference is how we treat XML's attributes is different. In antchfx, attributes are not separate nodes while in IDR attributes are first class citizens.
Codecov Report
@@ Coverage Diff @@ ## master #75 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 32 33 +1 Lines 1354 1421 +67 ========================================= + Hits 1354 1421 +67
Continue to review full report at Codecov.
|
wangjia007bond approved these changes Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Code/algo mostly inherits from https://github.com/antchfx/xmlquery/blob/master/query.go but the primary difference is how we treat XML's attributes is different. In antchfx, attributes are not separate nodes while in IDR attributes are first class citizens.