Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Conversation

@JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Apr 23, 2019

Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com

/assign @simonswine

Also add sha1 hash to file name to enable version control between files

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2019
@jetstack-bot jetstack-bot requested a review from simonswine April 23, 2019 18:45
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@simonswine
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2019
@jetstack-bot jetstack-bot merged commit 9440811 into master May 14, 2019
@JoshVanL JoshVanL deleted the update-diagram branch July 30, 2019 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

4 participants