Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Move static manifests from demo to deploy #107

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Move static manifests from demo to deploy #107

merged 1 commit into from
Jan 8, 2020

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Nov 6, 2019

Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com

Moves static manifests from demo to deploy since that makes more logic sense
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 6, 2019
@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Nov 6, 2019

/assign @simonswine
@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2019
@simonswine
Copy link
Contributor

Needs rebase or close

/assign @JoshVanL
/unassign
@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Jan 6, 2020
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jan 6, 2020

/unassign
/assign @simonswine
@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Jan 6, 2020
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jan 6, 2020

/retest
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jan 6, 2020 •
edited
Loading

Not sure why this is now failing.
The previous was a Github.com resolve flake
/retest
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jan 7, 2020

/pull pull-kube-oidc-proxy-e2e-v1-16
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jan 7, 2020

/test pull-kube-oidc-proxy-e2e-v1-16
jenkinsswine
jenkinsswine approved these changes Jan 8, 2020
View reviewed changes
Copy link

@jenkinsswine jenkinsswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jenkinsswine, JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jetstack-bot
Copy link
Contributor

@jenkinsswine: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@simonswine
Copy link
Contributor

Needs another rebase
/unassign
/assign @JoshVanL
@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Jan 8, 2020
@JoshVanL
Move static manifests from demo to deploy
22edf03 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jan 8, 2020

/unassign
/assign @simonswine
@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Jan 8, 2020
@simonswine
Copy link
Contributor

/lgtm
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@jetstack-bot jetstack-bot merged commit 52ceb13 into jetstack:master Jan 8, 2020
@jetstack-bot jetstack-bot added this to the v0.2 milestone Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

4 participants

@JoshVanL @simonswine @jetstack-bot @jenkinsswine