[VC-35738] Hide the client-go reflector warning logs #624
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ref: VC-33564
The aim of this PR is to filter out the warnings logged in client-go/tools/cache/reflector.go when a resource group version is not installed in the Kubernetes API server.
An example of such a warning, with
--logging-format=json
:Hiding the warnings is achieved by creating a filtering logr.LogSink and assigning that to the default klog logger.
However it does not seem possible to maintain the correct file and line numbers when wrapping the logger this way.
I discussed this with the klog authors and they confirm that there are probably bugs in the way the klog functions unwrap the stack:
In that thread on Slack, I learned from the klog authors that there is an in progress PR which will remove this distracting warning message:
So I will close this PR.