Update jest-diff to remove colors from no diff message #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
thymikee approved these changes Jun 25, 2020
Member
thymikee left a comment
thymikee left a comment There was a problem hiding this comment.
👍 can we update all other Jest deps to 26.1 as well? :)
Updates to the latest jest-diff which now supports removing color codes from "no visual difference" message. A test has been added to confirm this and prevent regressions in the future. All jest packages in use have been updated as part of this commit. Fixes jest-community#129
alistairjcbrown force-pushed the bump-jest-diff branch from 30fd0b0 to f70d915 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updates to the latest jest-diff which now supports removing color codes
from "no visual difference" message. A test has been added to confirm
this and prevent regressions in the future.
This is a follow-on PR from PR #123.
There is a dependabot PR already up for this bump (PR #170) and other jest dependencies, but this PR includes a test for when there is no difference. These PRs should close automatically once this lands.
Fixes #129