feat(breaking): Output jest mock function names in snapshot diff #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use same serializers as jest-snapshot when serializing react components rendered by react-test-renderer. Fixes jest-community#106
Contributor Author
| Using |
With the React serializer updated to use `prettyFormat`, this now supports diffing React fragments when comparing a single element to multiple elements returned. Adding test to confirm output. Fixes jest-community#111
Contributor Author
| @thymikee give me a shout if there's anything that needs updated or added to this PR. |
thymikee reviewed May 5, 2020
Member
thymikee left a comment
thymikee left a comment There was a problem hiding this comment.
Awesome, using serializers from jest-snapshot totally makes sense 👍
Makes use of the same serializers used for printing, in the react serializer diff options which set up the A and B diff annotations.
Contributor Author
| @thymikee Good catch - added serializers in diff options and updated test to show new annotations output 👍 |
thymikee approved these changes May 6, 2020
thymikee changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use same serializers as jest-snapshot when serializing React components
rendered by react-test-renderer.
With the React serializer updated to use
prettyFormat, this nowsupports diffing React fragments when comparing a single element to
multiple elements returned. Adding test to confirm output.
Fixes #106
Fixes #111