Skip to content

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Dec 26, 2021

Came across this when picking up work for eslint-plugin-jest-dom - seems like a pretty cool thing to have for us too.

@G-Rath G-Rath requested a review from SimenB December 26, 2021 04:41
@G-Rath G-Rath closed this Dec 26, 2021
@G-Rath G-Rath reopened this Dec 26, 2021
@G-Rath G-Rath merged commit 4fe66ce into main Dec 26, 2021
@G-Rath G-Rath deleted the add-smoke-testing branch December 26, 2021 04:55
with:
node-version: 16
- run: |
npm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Npm?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can't get yarn link working - happy if you want to have a crack at it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yarn had some issues to get package linking working across host and docker container. Same issues were seen with older npm versions: jsx-eslint/eslint-plugin-react#3120 (comment).

- uses: AriPerkkio/eslint-remote-tester-run-action@v2
with:
issue-title: 'Results of weekly scheduled smoke test'
eslint-remote-tester-config: smoke-test/eslint-remote-tester.config.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is missing?

@G-Rath
Copy link
Collaborator Author

G-Rath commented Dec 26, 2021

@SimenB yeah I merged this by mistake 😅 have fixed in #1003

@github-actions
Copy link

🎉 This PR is included in version 25.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants