Skip to content

Fix deprecated rand.Seed #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jesseduffield merged 1 commit into from
Mar 20, 2023
Merged

Fix deprecated rand.Seed #2515

jesseduffield merged 1 commit into from
Mar 20, 2023

Conversation

@stefanhaller
Copy link
Collaborator

@stefanhaller stefanhaller commented Mar 19, 2023

  • PR Description

Fix a linter warning that I get locally. No idea why it doesn't also show up on CI.

SA1019: rand.Seed has been deprecated since Go 1.20 and an alternative has been
available since Go 1.0: Programs that call Seed and then expect a specific
sequence of results from the global random source (using functions such as Int)
can be broken when a dependency changes how much it consumes from the global
random source. To avoid such breakages, programs that need a specific result
sequence should use NewRand(NewSource(seed)) to obtain a random generator that
other packages cannot access. (staticcheck)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2023 •
edited
Loading

Uffizzi Preview deployment-19434 was deleted.
@jesseduffield jesseduffield merged commit 4b67a45 into jesseduffield:master Mar 20, 2023
@jesseduffield
Copy link
Owner

jesseduffield commented Mar 20, 2023

Nice one
@stefanhaller stefanhaller deleted the fix-deprecated-rand-seed branch March 20, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@stefanhaller @jesseduffield