Fix setting gui.selectedLineBgColor as a hex value #2483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Uffizzi Preview Environment |
Collaborator
| This looks like it should fix #1749 , so thanks for that :) |
Owner
jesseduffield left a comment
jesseduffield left a comment There was a problem hiding this comment.
Code looks good. Any chance you could add a test for this function that asserts on the new behaviour?
The tests show that setting a hex color doesn't work; we'll fix that in the next commit.
stefanhaller force-pushed the fix-setting-selectedLineBgColor branch from 139b709 to 63e8b8c Compare 
Collaborator Author
| First time I wrote a unit test file from scratch, hope this looks ok. I used my usual preferred way of introducing the test first to demonstrate what's broken, let me know if you prefer to squash the two commits. |
Owner
| Perfect :) Happy to keep that as two commits. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When trying to set
gui.selectedRangeBgColorto a hex value, it would get set to nothing instead. Named colors worked though.I don't understand why this didn't seem to affect any of the other colors that are set with
GetTextStyle, e.g.selectedLineBgColor. But the fix here still seems right to me.go run scripts/cheatsheet/main.go generate)docs/Config.md) have been updated if necessary