Migrate patch building tests #2475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Uffizzi Preview Environment |
jesseduffield force-pushed the migrate-patch-building-tests branch from e310e22 to 7a0c870 Compare 
| | ||
| // milliseconds we'll wait when an assertion fails. | ||
| var retryWaitTimes = []int{0, 1, 1, 1, 1, 1, 5, 10, 20, 40, 100, 200, 500, 1000, 2000, 4000} | ||
| var retryWaitTimes = []int{0, 1, 1, 1, 1, 1, 5, 10, 20, 40, 100} |
Collaborator
There was a problem hiding this comment.
Thanks for this! 😄 (I was always wondering why we have to wait so long.)
Owner Author
There was a problem hiding this comment.
Ah actually that was accidentally committed: I was reducing the timeout for my own local usage. But if CI can handle it then I'm fine to keep it that way across the board
Collaborator
There was a problem hiding this comment.
Ah. 😄
Maybe we could have an environment variable that is only set on CI and that makes it wait longer.
jesseduffield commented Feb 25, 2023
| return self.shell | ||
| } | ||
| | ||
| // this will look for a list item in the current panel and if it finds it, it will |
Owner Author
There was a problem hiding this comment.
moving to view_driver.go
jesseduffield commented Feb 25, 2023
| Tap(func() { | ||
| t.ExpectPopup().Confirmation(). | ||
| Title(Contains("")). | ||
| Content(Contains("")). |
Owner Author
There was a problem hiding this comment.
whoops forgot to populate these
jesseduffield force-pushed the migrate-patch-building-tests branch 4 times, most recently from f6a9b1d to 0cb637c Compare 
jesseduffield force-pushed the migrate-patch-building-tests branch from 0cb637c to 9c64508 Compare 
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Description
Migrates the patch building tests
go run scripts/cheatsheet/main.go generate)docs/Config.md) have been updated if necessary