Skip to content

Conversation

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Feb 19, 2023

  • PR Description

This PR:

  • Migrates some more tests
  • adds a visual snapshot for failing tests to help investigating
  • fixes a bug with the undo controller
  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc
if rebaseFinishCommitSha == "" {
if ok, _ := utils.FindStringSubmatch(reflogCommit.Name, `^\[lazygit undo\]`); ok {
counter++
} else if ok, _ := utils.FindStringSubmatch(reflogCommit.Name, `^\[lazygit redo\]`); ok {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caught a bug here

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2023

Uffizzi Preview Environment deployment-16582

☁️ https://app.uffizzi.com/github.com/jesseduffield/lazygit/pull/2450

📄 View Application Logs etc.

What is Uffizzi? Learn more

@jesseduffield jesseduffield changed the title allow syncing tests from vscode more integration test migrations Feb 19, 2023
@jesseduffield jesseduffield merged commit b54b8ae into master Feb 19, 2023
@jesseduffield jesseduffield deleted the migrate-more-tests branch February 19, 2023 04:51
ExtraCmdArgs: "",
Skip: false,
SetupConfig: func(config *config.AppConfig) {
config.UserConfig.Git.AutoFetch = false
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't need these config lines: these were present due to copy+pasting tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant