Skip to content

Conversation

@stefanhaller
Copy link
Collaborator

  • PR Description

When copying a range of diff lines to the clipboard, the last line wouldn't end with a line feed. This made it inconvenient to paste the copied block into a text document. Ensure that the last line ends with a LF too.

I didn't add a test for this, let me know if you think it's worth doing that.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2023

Uffizzi Preview Environment deployment-12623

☁️ https://app.uffizzi.com/github.com/jesseduffield/lazygit/pull/2395

📄 View Application Logs etc.

What is Uffizzi? Learn more

@jesseduffield
Copy link
Owner

Thanks for making this :) Merging

@jesseduffield jesseduffield merged commit d8c7d47 into jesseduffield:master Jan 29, 2023
@stefanhaller stefanhaller deleted the trailing-lf-when-copying-diff-lines branch January 29, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants