Skip to content

more integration test migrating #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jesseduffield merged 3 commits into from
Dec 20, 2022
Merged

more integration test migrating #2325

jesseduffield merged 3 commits into from
Dec 20, 2022

Conversation

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Dec 20, 2022 •
edited
Loading

  • PR Description
    This also fixes a bug where in sandbox mode, user config changes wouldn't apply

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc
@jesseduffield jesseduffield merged commit c77df59 into master Dec 20, 2022
@jesseduffield jesseduffield deleted the migrate-even-more-tests branch December 20, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jesseduffield