Skip to content

migrate more tests #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jesseduffield merged 4 commits into from
Dec 20, 2022
Merged

migrate more tests #2323

jesseduffield merged 4 commits into from
Dec 20, 2022

Conversation

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Dec 20, 2022 •
edited
Loading

  • PR Description
  • migrates a couple more tests
  • bumps gocui
  • removes snapshots from new integration tests

Snapshots were a no-brainer for the old integration test approach, but they're brittle and it's hard to understand why a snapshot differs from what is expected. With the new approach we're going to rely entirely on in-test assertions.

This means that it's possible that issues will arise that tests won't catch, which snapshots would have caught, but the solution to that is to come up with more extensive assertions within our tests.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc
@jesseduffield jesseduffield merged commit 6ec88ce into master Dec 20, 2022
@jesseduffield jesseduffield deleted the migrate-more-tests branch December 20, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jesseduffield