Adds the possibility to mount an existing volume #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| I don't think it can work this way. In any case, it should be already doable using the |
Is the only way to mount a volume in pod A into pod B is through the YAML field? |
Member
| Coming back on this PR, I fail to understand what is the use case. The current pod template model in the plugin defines volumes which get mounted in all containers. If you want something more specific, use the The example about EKS IAM service account doesn't seem to apply here: the admission controller injects both volume and volume mount. Why would you need to declare an additional volume mount? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As an example, when a k8s cluster runs on EKS (and that OIDC is configured properly), each pod that gets started on the cluster (including the jenkins-agents) gets a Projected Volume added automagically (usefull for AWS authentication, but I digress)
This patch adds the possibility of adding a
volumeMountjust by specifying a volume name (ie: without the template adding thevolumedefinition).