Drop Netty transport #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| jenkinsci/docker-build-step-plugin#86 has been merged and released, so nothing is blocking the merge and release of this PR as far as I know. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Netty-based transport adds significant weight to the JAR and complexity to the linker, and as of jenkinsci/docker-build-step-plugin#86 it won't be used anywhere except https://github.com/jenkinsci/nodepool-agents-plugin/blob/db1ddd9438516b676ef3accbd97df0ee1a875879/src/test/java/com/rackspace/jenkins_nodepool/NodePoolRule.java#L41 (which only has 40 installations).