performance optimisations #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits August 19, 2016 09:37
| Great! Thanks! |
| style[key] && theme[key].indexOf(style[key]) === -1 | ||
| ? `${style[key]} ${theme[key]}` | ||
| : theme[key] || style[key] | ||
| })), style) |
There was a problem hiding this comment.
Now passed style is mutated in reduce so a theme which is in context gets mutated too.
There was a problem hiding this comment.
oops you are right @raveclassic, will fix that, hopefully it doesnt slow down much, thanks for keeping an eye on this!
There was a problem hiding this comment.
did a quick fix, still performs better, here:
https://github.com/javivelasco/react-css-themr/pull/13/files
There was a problem hiding this comment.
Sorry, honestly I did not dig deep before merging but I wanted to give a better look before releasing. Thanks for keeping an eye on it @raveclassic!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I did some performance optimizations to your
themeablefunction, since I was having issues inside ascrollevent.Basically avoid looping through keys that are not meant to belong in the original theme, and using
Object.assignwhich seems to be faster.All tests are passing.