Support :has-exe as well #1658
Merged
Support :has-exe as well #1658
+5 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a companion change to spork's issue As implemented, :has-been-script didn't quite mean what was intended. :has-exe should be an improvement. To prevent breakage, both :has-bin-script and :has-exe should be supported for a while in both spork and janet. Eventually :has-bin-script can be retired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a companion change to spork's #252 to address spork's #247 and a bit of #1648.
Please see spork's #247 for details.
As implemented,
:has-been-scriptdidn't quite mean what was intended. The intent of:has-exeis to improve on the current:has-been-scriptbehavior (in spork) but also to act as an eventual replacement.To prevent breakage, both
:has-bin-scriptand:has-exeshould be supported for a while in both spork and janet. Eventually:has-bin-scriptcan be retired.I hope some folks will try this and the companion change 🙏