Fix LDFLAGS Usage in Makefile #1624
Merged
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR fixes what appears to be a typo `LDFLAGS` written with an additional `_` in the Makefile for setting the default linker flags for `libjanet`.
11 tasks
Contributor
| I've looked into this a bit and haven't found anything definitive, but FWIW there are hits for both Not having much luck with determining whether both are valid for some environments and/or one has been deprecated. May keep looking. |
Member
| LDFLAGS is the right one, LD_FLAGS is clearly a typo. Good catch, @nlordell . |
Contributor
| On a peripheral note, there do seem to be places where
There are far more hits for |
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes what appears to be a typo
LDFLAGSwritten with an additional_in the Makefile for setting the default linker flags forlibjanet.