Brief: Add Arm64 .msi support on Windows #1541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Looks good to me, but is there any real need to change |
Summary: Small update to add Windows on Arm64 support. Also requires the latest version 3.14 of the WiX toolset.
Contributor Author
| just pushed an update that removes the change in WiX uses "arm64" and Python uses "arm64". Clang and Rust use "aarch64" so there is no clear answer. |
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Small update to add Windows on Arm64 support. This does require changing the (os/arch) value from 'aarch64' to 'arm64' just for Windows on Arm.
Also requires the latest version 3.14 of the WiX toolset.