Skip to content

Conversation

@tuunit
Copy link
Collaborator

@tuunit tuunit commented Jun 3, 2023

  • add direct urls for comments
  • replace custom url handling with html_url property provided by github api

fixes #54

has been tested here:

https://github.com/tuunit/github-activity-testing
https://github.com/tuunit/github-activity-testing/actions/runs/5165369229

@jamesgeorge007 jamesgeorge007 changed the title add direct urls for comments feat: add direct urls for comments Jun 4, 2023
@jamesgeorge007
Copy link
Owner

@tuunit, let's follow conventional commits for the PR titles and commit messages. Also, are you planning to include only this commit in the next release; in that case, let's have the version bump in this PR as well. Since this is an enhancement I think it should be a minor bump to v0.5.0.

@tuunit
Copy link
Collaborator Author

tuunit commented Jun 4, 2023

@tuunit, let's follow conventional commits for the PR titles and commit messages. Also, are you planning to include only this commit in the next release; in that case, let's have the version bump in this PR as well. Since this is an enhancement I think it should be a minor bump to v0.5.0.

@jamesgeorge007 Yeah, perfect I'm a fan of the conventional commit standard. It is used in all official google cloud repositories as well. I was thinking about that and was considering to upgrade to v0.5.0 but then decided against it. Because it seems like such a minor change but obviously you are right, it is essentially a new feature and therefore I bumped the version to v0.5.0

- add direct urls for comments and replace custom url handling with html_url property provided by github api - remove redundant else branches - separate into if blocks for better readability - remove unnecessary constant for github base url Co-authored-by: James George <jamesgeorge998001@gmail.com>
@tuunit
Copy link
Collaborator Author

tuunit commented Jun 4, 2023

@jamesgeorge007 All changes are done and I squashed the commits and changed the commit message to follow the conventional standard 🥳

@jamesgeorge007
Copy link
Owner

@tuunit, there is a regression with the URL generated for releaseEvent #99. Let's include a fix for the same in this release. Let's create an RC branch and target this PR to the same.

@tuunit tuunit changed the base branch from master to rc/0.5.0 June 6, 2023 07:45
@tuunit tuunit merged commit a5ec258 into jamesgeorge007:rc/0.5.0 Jun 6, 2023
@tuunit tuunit mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants