Skip to content

Conversation

@jakubjirous
Copy link
Owner

@jakubjirous jakubjirous commented Jan 7, 2023

All Longest Strings


PR Checklist:

  • Understand the problem
    • You know what is known
    • You know what is unknown
    • You thought throw some edge cases that could potentially happen
  • Devise a plan
    • Writing a comment to code challenge what you want to do
    • Showing the ability to take that problem and break it down to the parts
    • Take the larger problem and take it down into smaller problems
  • Execute the plan
    • Turning into an actual code
  • Review your solution
    • Time to consider if there were a better approach
    • Backwards realizing room for improvements
  • Unit test
    • Cover your result with appropriate assertions

@octocat 👍 This PR looks great - it's ready to merge! :shipit:

9) all longest strings
@jakubjirous jakubjirous force-pushed the feature/all-longest-strings branch from e18dcf4 to ee51af2 Compare January 7, 2023 20:12
@jakubjirous jakubjirous enabled auto-merge January 7, 2023 20:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2023

@jakubjirous jakubjirous merged commit dd15928 into main Jan 7, 2023
@jakubjirous jakubjirous deleted the feature/all-longest-strings branch January 7, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant