adding an environment.yml to specify python version #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Awesome – thanks for looking into this! |
mwouts pushed a commit to mwouts/PythonDataScienceHandbook that referenced this pull request Jun 23, 2019
adding an environment.yml to specify python version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hey @jakevdp , I believe that this should get the install working with Binder! It doesn't fix the underlying numpy/skimage/python3.6 trifecta bug, but works around it. AKA, it still won't work if you just
pip install -r requirements.txtif you are running Python 3.6 (maybe worth mentioning in the readme?). This PR just adds anenvironment.ymlfile that pins the python version at 3.5. I tested it on my fork and mybinder.org was able to build it just fine!