Upgrade to Flutter 3.10 + minor bug fixes #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BenPoell commented May 27, 2023
BenPoell commented - fixed problems coming with Flutter 3.10
- found some null checker exceptions during testing + fixed them
- unfortunately made a bracket wrong, cause an endless loop but found it in testing + fixed it
koutja reviewed Jul 9, 2023
| } | ||
| | ||
| Widget listWidget = ListView.builder( | ||
| physics: ClampingScrollPhysics(), |
There was a problem hiding this comment.
Please add for BoardView customization 2 arguments Key? listViewKey and ScrollPhysics? listViewPhysics
I need these settings to control the offset across entire pages
Widget listWidget = ListView.builder( key: listViewKey, physics: listViewPhysics ?? const ClampingScrollPhysics() , ...Example:
Widget listWidget = ListView.builder( key: const PageStorageKey('boardview'), physics: const PageScrollPhysics(),
There was a problem hiding this comment.
Hi @koutja kindly have this PR go in if what you've requested is a new feature it can be done on another PR, some of us depend on this. Thanks a lot.
philip-plateaumed approved these changes Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.